Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid capturing Snapshots for previously digested codegen outputs #7241

Merged
merged 7 commits into from
Feb 15, 2019
Merged

Avoid capturing Snapshots for previously digested codegen outputs #7241

merged 7 commits into from
Feb 15, 2019

Commits on Feb 14, 2019

  1. Remove PathStat from Snapshot API, since it is not roundtrippable via… 

    … a Digest.
    @stuhood
    stuhood committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    69f196e View commit details
    Browse the repository at this point in the history

  2. Implement contents_for_directory and expand_directory in terms of a g… 

    …eneric walk method.
    @stuhood
    stuhood committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    bb3d31d View commit details
    Browse the repository at this point in the history

  3. Add a Digest hint to PathGlobsAndRoot, and use it to bypass Snapshot … 

    …capture if stored.
    @stuhood
    stuhood committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    ef8843c View commit details
    Browse the repository at this point in the history

  4. Extract the Digest.load/Digest.dump methods from the RSC task and… 

    … reuse in SimpleCodegenTask.
    @stuhood
    stuhood committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    5735a03 View commit details
    Browse the repository at this point in the history

  5. Fix go thrift generation, which overrides the synthetic_target_dir,… 

    … and was thus observing the digest.
    @stuhood
    stuhood committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    2180cfe View commit details
    Browse the repository at this point in the history

  6. Review feedback.

    @stuhood
    stuhood committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    5e6c2a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. Remove literal-order-preservation from Snapshot, and add a facility t… 

    …o `java_wire_library` to restore it. Fixes pantsbuild#5802.
    @stuhood
    stuhood committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    47cb0ee View commit details
    Browse the repository at this point in the history