Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create infrastructure for running interactive local process #8495

Merged
merged 11 commits into from
Oct 31, 2019
Merged

Create infrastructure for running interactive local process #8495

merged 11 commits into from
Oct 31, 2019

Commits on Oct 30, 2019

  1. make keyboardinterrupt capturing in rules work

    @cosmicexplorer @gshuflin
    cosmicexplorer authored and gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    6dc097f View commit details
    Browse the repository at this point in the history

  2. clean up and make code correct

    @cosmicexplorer @gshuflin
    cosmicexplorer authored and gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    d95a54e View commit details
    Browse the repository at this point in the history

  3. use list .pop(0) and remove deque

    @cosmicexplorer @gshuflin
    cosmicexplorer authored and gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    d7b1940 View commit details
    Browse the repository at this point in the history

  4. Create InteractiveRunner type + run @console_rule 

    Draft of what an interactive process runner might look like
    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    f5700e5 View commit details
    Browse the repository at this point in the history

  5. Handle SIGINT in python 

    Instead of establishing a rust signal handler, use the ExceptionSink
infrastructure that already exists to selectively ignore SIGINT. In the
V2 engine, a SIGINT raised when execution is in rust does not get
handled by the python signal handler until sometime after the engine is
finished executing a goal, which is why the existing `ignoring_sigint`
context in `ExceptionSink` does not work (it successfuly increments and
then decrements _threads_ignoring_sigint; but the signal is only handled
*after* that happens).
    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    9bf0fd0 View commit details
    Browse the repository at this point in the history

  6. Get rid of enum for controlling where subprocess executes 

    Use a bool flag instead to make it easier to pass across FFI.
    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    3e30b2c View commit details
    Browse the repository at this point in the history

  7. Fix BUILD file and dependencies

    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    c5648c3 View commit details
    Browse the repository at this point in the history

  8. Respond to PR

    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    5a87acd View commit details
    Browse the repository at this point in the history

  9. use tuples()

    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    48538e1 View commit details
    Browse the repository at this point in the history

  10. Need to fix the build file again.

    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    e1bace0 View commit details
    Browse the repository at this point in the history

  11. Fix type error in toggle method

    @gshuflin
    gshuflin committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    81a7f66 View commit details
    Browse the repository at this point in the history