fix: contactKDF iteration count fixed for key sizes larger than 256 bits

panva · Jan 25, 2020 · 70ff222 · 70ff222
1 parent e3ad39f
commit 70ff222
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/lib/jwa/ecdh/derive.js b/lib/jwa/ecdh/derive.js
@@ -2,7 +2,7 @@ const { createHash } = require('crypto')
 const ecdhComputeSecret = require('./compute_secret')
 
 const concat = (key, length, value) => {
-  const iterations = Math.ceil(length / 256)
+  const iterations = Math.ceil(length / 32)
   let res
 
   for (let iter = 1; iter <= iterations; iter++) {

diff --git a/test/jwe/smoke.P-256K.test.js b/test/jwe/smoke.P-256K.test.js
@@ -26,7 +26,6 @@ const dKey = asKey(key)
 
 ;[...eKey.algorithms('wrapKey'), ...eKey.algorithms('deriveKey')].forEach((alg) => {
   ENCS.forEach((enc) => {
-    if (alg === 'ECDH-ES' && ['A192CBC-HS384', 'A256CBC-HS512'].includes(enc)) return
     test(`key ${type} > alg ${alg} > ${enc}`, success, eKey, dKey, alg, enc)
     test(`key ${type} > alg ${alg} > ${enc} (negative cases)`, failure, eKey, dKey, alg, enc)
   })

diff --git a/test/jwe/smoke.test.js b/test/jwe/smoke.test.js
@@ -28,7 +28,6 @@ Object.entries(fixtures.PEM).forEach(([type, { private: key, public: pub }]) =>
 
   ;[...eKey.algorithms('wrapKey'), ...eKey.algorithms('deriveKey')].forEach((alg) => {
     ENCS.forEach((enc) => {
-      if (alg === 'ECDH-ES' && ['A192CBC-HS384', 'A256CBC-HS512'].includes(enc)) return
       test(`key ${type} > alg ${alg} > ${enc}`, success, eKey, dKey, alg, enc)
       test(`key ${type} > alg ${alg} > ${enc} (key as bare input)`, success, pub, key, alg, enc)
       if (keyObjectSupported) {
@@ -71,7 +70,6 @@ Object.entries(fixtures.PEM).forEach(([type, { private: key, public: pub }]) =>
   const eKey = asKey({ kty: 'RSA', e: rsa.e, n: rsa.n })
   eKey.algorithms('wrapKey').forEach((alg) => {
     ENCS.forEach((enc) => {
-      if (alg === 'ECDH-ES' && ['A192CBC-HS384', 'A256CBC-HS512'].includes(enc)) return
       test(`key RSA (min) > alg ${alg} > ${enc}`, success, eKey, dKey, alg, enc)
       test(`key RSA (min) > alg ${alg} > ${enc} (negative cases)`, failure, eKey, dKey, alg, enc)
     })