We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert
Describe the bug
No dependencies are listed in package.json, however, the browser package appears to depend on assert.
package.json
To Reproduce
See https://unpkg.com/browse/[email protected]/dist/browser/util/decode_protected_header.js
There's a non-relative import on the first line:
import { ok as assert } from 'assert';
If the assert npm module is not present, this will not resolve.
Expected behaviour
Either for there to not be a dependency on assert, or for assert to be listed as a dependency in package.json.
Environment:
jose
Additional context
The text was updated successfully, but these errors were encountered:
The intention is to not have a dependency, this is an oversight i'll get fixed.
Sorry, something went wrong.
d9d4a5f
Fixed in https://github.com/panva/jose/releases/tag/v3.12.3
Quick as usual - thanks!
Remove browser dependency workaround
aadda2a
Filip released a fix in upstream jose: panva/jose#206 (comment)
No branches or pull requests
Describe the bug
No dependencies are listed in
package.json
, however, the browser package appears to depend onassert
.To Reproduce
See https://unpkg.com/browse/[email protected]/dist/browser/util/decode_protected_header.js
There's a non-relative import on the first line:
If the
assert
npm module is not present, this will not resolve.Expected behaviour
Either for there to not be a dependency on
assert
, or forassert
to be listed as a dependency inpackage.json
.Environment:
jose
version: 3.12.2Additional context
jose
too. - looks like itThe text was updated successfully, but these errors were encountered: