Added possibility to set binary path of pngquant manually #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,11 @@ function PngQuant(pngQuantArgs) { | |||
| util.inherits(PngQuant, Stream); | |||
|
|
|||
| PngQuant.getBinaryPath = memoizeAsync(function (cb) { | |||
| if(this.binaryPath !== undefined) { | |||
| cb(this.binaryPath); | |||
There was a problem hiding this comment.
You seem to be releasing Zalgo here by calling the callback immediately. Also, it should be cb(null, this.binaryPath); so this.binaryPath isn't interpreted as an error.
|
Thanks for the contribution! I'm cool with the feature, but have a quibble with the implementation -- se my comment :) |
|
Sorry for the mistakes, hope I fixed them now. Is this ok to merge now or are there still things that need a fix? |
|
👍, merging. |
|
Released as 1.1.0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to set binary path of pngquant manually. Pretty useful when using this tool and if you want to hijack the command line with for instance a Docker container. This would also make it possible to use a specific version (or fork) of pngquant on a system where multiple versions are installed.