Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-config-prettier to version 5.0.0 #31

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 18, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ eslint-config-prettier (^4.1.0 → ^5.0.0) · Repo · Changelog

Release Notes

5.0.0 (from changelog)

  • Removed: react/self-closing-comp. This rule was added in v4.1.0 not because it conflicted with Prettier but because it was unnecessary when using Prettier. However, in v1.18.0 Prettier stopped converting empty elements to self-closing elements. So the rule is not unnecessary anymore.

    If you use Prettier v1.17.1 or older you should be able to upgrade eslint-config-prettier to v5.0.0 without having to do anything else.

    If you use Prettier v1.18.0 or newer, you might get lint errors about for example changing <div></div> into <div />. You have two options:

    • Run eslint --fix if you prefer to enforce self-closing elements where possible. This should fix all the errors.
    • Add "react/self-closing-comp": "off" to your ESLint config if you use autofix from your editor and you face the same issue as Prettier did.
  • Changed: Node.js 6 is no longer officially supported, but v5.0.0 should still work with it.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 18, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.769% when pulling fb10840 on depfu/update/npm/eslint-config-prettier-5.0.0 into d70309a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.769% when pulling fb10840 on depfu/update/npm/eslint-config-prettier-5.0.0 into d70309a on master.

@papandreou papandreou merged commit ee805e3 into master Jun 18, 2019
@depfu depfu bot deleted the depfu/update/npm/eslint-config-prettier-5.0.0 branch June 18, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants