In track_associations, only check db if no config #640
Conversation
This allows users who need to precompile assets without a database to configure `track_associations = false`. See discussion: #636
| @track_associations ||= PaperTrail::VersionAssociation.table_exists? | ||
| @track_associations.nil? ? | ||
| PaperTrail::VersionAssociation.table_exists? : | ||
| @track_associations |
There was a problem hiding this comment.
We could actually simplify this to @track_associations && PaperTrail::VersionAssociation.table_exists?, right? Not as explicitly obvious what is going on, but my thought is that this will actually prevent errors in scenarios where users try to turn the feature on without having the underlying required table. Alternatively we could raise an error or a warning in those scenarios. Thoughts?
There was a problem hiding this comment.
We could actually simplify this to @track_associations && PaperTrail::VersionAssociation.table_exists?, right?
That conjunction would require a database connection, and thus would not fix #636
|
Ahh I see |
In track_associations, only check db if no config
|
I'm thinking it may make sense to merge this upstream into the |
Sounds good. I'll go ahead and do that merge if you haven't already, and I'll add a line to the changelog about it. What's your timeline for a 4.0.1 release, because I think we've done enough work to justify one, it's just a matter of tracking down what we need to backport. |
This allows users who need to precompile assets without a database
to configure
track_associations = false.See discussion: #636