Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface RPC error in trace #17

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

ipatka
Copy link
Contributor

@ipatka ipatka commented Aug 1, 2023

Rather than assuming a rate limit error, return the error message from the RPC node

This far from perfect as it doesn't account for other error cases. Ideally we could pattern match to find the exact error case but different RPC providers return diff error formats. But I think this is potentially more helpful when debugging dataset requests

ex.

Alchemy
Screen Shot 2023-08-01 at 2 59 01 PM

RETH with traces disabled
Screen Shot 2023-08-01 at 2 58 42 PM

Before this PR:

Screen Shot 2023-08-01 at 3 04 04 PM

TODOs

  • Add similar error handling to other dataset files

@sslivkoff sslivkoff merged commit 91a4b17 into paradigmxyz:main Aug 2, 2023
3 checks passed
@sslivkoff
Copy link
Member

awesome this is very useful to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants