Skip to content

Commit

Permalink
Revert "test(ethereum): ignore invalid string sequence in ethereum st…
Browse files Browse the repository at this point in the history
…ate tests (#3307)" (#3937)
  • Loading branch information
shekhirin authored Jul 26, 2023
1 parent adce7ea commit 9adab0b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 26 deletions.
10 changes: 0 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions testing/ef-tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,4 @@ tokio = "1.28.1"
walkdir = "2.3.3"
serde = "1.0.163"
serde_json.workspace = true
thiserror.workspace = true
serde_bytes = "0.11.9"
thiserror.workspace = true
14 changes: 0 additions & 14 deletions testing/ef-tests/src/models.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,6 @@ pub struct BlockchainTest {
#[serde(default)]
/// Engine spec.
pub self_engine: SealEngine,
#[serde(rename = "_info")]
#[allow(unused)]
info: BlockchainTestInfo,
}

#[derive(Debug, PartialEq, Eq, Deserialize)]
struct BlockchainTestInfo {
#[serde(rename = "filling-rpc-server")]
#[allow(unused)]
// One test has an invalid string in this field, which breaks our CI:
// https://github.com/ethereum/tests/blob/6c252923bdd1bd5a70f680df1214f866f76839db/GeneralStateTests/stTransactionTest/ValueOverflow.json#L5
// By using `serde_bytes::ByteBuf`, we ignore the validation of this field as a string.
// TODO(alexey): remove when `ethereum/tests` is fixed
filling_rpc_server: serde_bytes::ByteBuf,
}

/// A block header in an Ethereum blockchain test.
Expand Down

0 comments on commit 9adab0b

Please sign in to comment.