chore(reth-execution-errors) no_std #10048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinezjorge
changed the title
emhane
previously requested changes
Aug 3, 2024
martinezjorge
force-pushed
the
reth-execution-errors-no_std
branch
from
097ff44
to
63f0313
Compare
martinezjorge
requested review from
rakita,
mattsse,
Rjected and
gakonst
as code owners
mattsse
requested changes
Aug 8, 2024
|
|
||
| pub mod trie; | ||
| pub use trie::*; | ||
|
|
||
| /// Transaction validation errors | ||
| #[derive(thiserror_no_std::Error, Debug, Clone, PartialEq, Eq)] | ||
| #[derive(Clone, Debug, Display, Eq, From, PartialEq)] |
There was a problem hiding this comment.
please impl From conversions manually where we had them
There was a problem hiding this comment.
no problem, done
| @@ -172,14 +205,13 @@ impl BlockExecutionError { | |||
| } | |||
|
|
|||
| /// Internal (i.e., not validation or consensus related) `BlockExecutor` Errors | |||
| #[derive(thiserror_no_std::Error, Debug)] | |||
| #[derive(Display, Debug, From)] | |||
mattsse
added
the
C-debt
shekhirin
force-pushed
the
reth-execution-errors-no_std
branch
from
deac851
to
fa23137
Compare
shekhirin
force-pushed
the
reth-execution-errors-no_std
branch
from
fa23137
to
d675e74
Compare
shekhirin
approved these changes
Aug 12, 2024
mattsse
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #9478
Adds
no_stdsupport forreth-execution-errors