fix: return only canonical blocks for history_by_* methods #10190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that these methods are not actually supposed to go to the database, instead they should be returning only canonical blocks. This means that we may need to check in-memory. The
state_by
method now defers to these methods, and differs in that it may return a pending block. Whereas thehistory_by
methods will not return a pending block.This should fix the constant:
logs seen now, since those use
history_by
methodsref #10186