Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: derive serde traits #10198

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

xJonathanLEI
Copy link
Contributor

Useful traits for some downstream applications and probably harmless to derive.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable, smol serde nit

Comment on lines 123 to 125
#[derive(Clone, PartialEq, Eq, Debug, Serialize, Deserialize)]
pub struct AccountProof {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do rename_all camel case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry should have checked other places where this is derived. Fixed now.

@mattsse mattsse added the C-enhancement New feature or request label Aug 8, 2024
@onbjerg onbjerg enabled auto-merge August 8, 2024 15:24
@onbjerg onbjerg added this pull request to the merge queue Aug 8, 2024
Merged via the queue into paradigmxyz:main with commit 75a501e Aug 8, 2024
33 checks passed
@xJonathanLEI xJonathanLEI deleted the dev/serde_traits branch August 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants