Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make additional validation tasks size configurable #10200

Merged
merged 5 commits into from
Aug 8, 2024
Merged

feat: make additional validation tasks size configurable #10200

merged 5 commits into from
Aug 8, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Aug 8, 2024 •
edited
Loading

Closes #10194

mattsse
mattsse requested changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, only a few smol nitpicks

crates/node/core/src/args/txpool.rs Outdated Show resolved Hide resolved
crates/node/core/src/args/txpool.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/config.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/config.rs Outdated Show resolved Hide resolved
@mattsse mattsse added A-tx-pool Related to the transaction mempool A-cli Related to the reth CLI labels Aug 8, 2024
mattsse
mattsse requested changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last doc nit :)

crates/node/core/src/args/txpool.rs Outdated Show resolved Hide resolved
mattsse
mattsse approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to update the book once more, then this is g2m

tysm!!

@mattsse mattsse enabled auto-merge August 8, 2024 21:53
@mattsse mattsse added this pull request to the merge queue Aug 8, 2024
Merged via the queue into paradigmxyz:main with commit 0216e78 Aug 8, 2024
33 checks passed
@nkysg nkysg deleted the task_size_clap branch August 10, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make additional validation tasks configurable via CLI
2 participants
@nkysg @mattsse