Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make Eth node launcher generic #10218

Merged
merged 1 commit into from
Aug 8, 2024
Merged

feat: make Eth node launcher generic #10218

merged 1 commit into from
Aug 8, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Aug 8, 2024

Towards #10160

Followup of #10212, creates EngineNodeLauncher from EthNodeLauncher, just by relaxing the restriction on engine types and using the generic EngineService introduced in #10212. reth binary is updated to use the generic node launcher.

mattsse
mattsse approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, moving this to builder makes sense, perhaps we want to eventually make this its own crate and instead move the launcher into the Node trait.

I'll rebase #10216 after this is merged

@mattsse mattsse added the C-enhancement New feature or request label Aug 8, 2024
@fgimenez fgimenez added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 63c71cf Aug 8, 2024
35 checks passed
@fgimenez fgimenez deleted the fgimenez/make-eth-node-launcher-generic branch August 8, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgimenez @mattsse