Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate engine2 for optimism #10222

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Aug 8, 2024

Closes #10160

Final step, introduce an experimental flag and use the new EngineNodeLauncher when it is set to true in optimism binary

@github-actions github-actions bot added the C-enhancement New feature or request label Aug 8, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will do it

Comment on lines +37 to +39
/// Enable the engine2 experimental features on op-reth binary
#[arg(long = "engine.experimental", default_value = "false")]
pub experimental: bool,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense

@fgimenez fgimenez added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit d2b0ff4 Aug 8, 2024
34 checks passed
@fgimenez fgimenez deleted the fgimenez/integrate-engine2-for-optimism branch August 8, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Engine2 for Optimism
2 participants