Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics for dropped outgoing messages #10225

Merged
merged 3 commits into from
Aug 9, 2024
Merged

feat: add metrics for dropped outgoing messages #10225

merged 3 commits into from
Aug 9, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Aug 8, 2024

Closes #10223

mattsse
mattsse requested changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, love the trace

crates/net/network/src/metrics.rs Outdated Show resolved Hide resolved
crates/net/network/src/session/mod.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Aug 8, 2024
@nkysg nkysg requested a review from mattsse August 9, 2024 12:41
mattsse
mattsse approved these changes Aug 9, 2024
View reviewed changes
crates/net/network/src/metrics.rs Outdated Show resolved Hide resolved
@mattsse mattsse enabled auto-merge August 9, 2024 12:48
@mattsse mattsse added this pull request to the merge queue Aug 9, 2024
Merged via the queue into paradigmxyz:main with commit c8a332f Aug 9, 2024
33 checks passed
@nkysg nkysg deleted the metrics_drop_messages branch August 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics for dropped outgoing messages
2 participants
@nkysg @mattsse