Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use exact max full peer count or round #10228

Merged
merged 1 commit into from
Aug 9, 2024
Merged

chore: use exact max full peer count or round #10228

merged 1 commit into from
Aug 9, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 8, 2024 •
edited
Loading

the + 1 skews the number of peers we should send txs in full if the sqrt is exact sqrt(4) + 1 is 3 and we already do >, so we would send txs in full to all peers

reth/crates/net/network/src/transactions/mod.rs

Line 457 in 05361de

if peer_idx > max_num_full || full_transactions.is_empty() {

@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Aug 8, 2024
Rjected
Rjected approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 66ddc5d Aug 9, 2024
34 checks passed
@mattsse mattsse deleted the matt/use-rounded-max-full branch August 9, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected