Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split validate_block_pre_execution into hardfork specific functions #10576

Merged
merged 4 commits into from
Aug 28, 2024
Merged

refactor: split validate_block_pre_execution into hardfork specific functions #10576

merged 4 commits into from
Aug 28, 2024

Conversation

willco-1
Copy link
Contributor

@willco-1 willco-1 commented Aug 27, 2024 •
edited by onbjerg
Loading

Closes #10568

onbjerg
onbjerg requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this on!

crates/consensus/common/src/validation.rs Outdated Show resolved Hide resolved
crates/consensus/common/src/validation.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg added C-debt Refactor of code section that is hard to understand or maintain A-consensus Related to the consensus engine labels Aug 28, 2024
@onbjerg onbjerg changed the title split validate_block_pre_execution into hardfork specific functions refactor: split validate_block_pre_execution into hardfork specific functions Aug 28, 2024
@onbjerg onbjerg enabled auto-merge August 28, 2024 10:04
@onbjerg onbjerg added this pull request to the merge queue Aug 28, 2024
Merged via the queue into paradigmxyz:main with commit 0013399 Aug 28, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split validate_block_pre_execution into hardfork specific functions
2 participants
@willco-1 @onbjerg