Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(op): empty receipts for block not counted by file client #10581

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix(op): empty receipts for block not counted by file client #10581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
293a3b0
Fix bug, empty receipts for block not counted by file client
emhane Aug 27, 2024
19f2ac5
Remove redundant debug statement
emhane Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/net/downloaders/src/file_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,6 @@ impl ChunkedFileReader {
T: FromReader,
{
if self.file_byte_len == 0 && self.chunk.is_empty() {
dbg!(self.chunk.is_empty());
// eof
return Ok(None)
}
Expand Down
3 changes: 0 additions & 3 deletions crates/optimism/cli/src/commands/import_receipts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,6 @@ where
debug_assert!(genesis_receipts.is_empty());
// this ensures the execution outcome and static file producer start at block 1
first_block = 1;
// we don't count this as decoded so the partial import check later does not error if
// this branch is executed
total_decoded_receipts -= 1; // safe because chunk will be `None` if empty
}

// We're reusing receipt writing code internal to
Expand Down
Loading