test: TransactionsProvider implementation of BlockchainProvider2<DB>
#10594
Conversation
shekhirin
changed the title
TransactionsProvider implementation of BlockchainProvider2<DB>TransactionsProvider implementation of BlockchainProvider2<DB>
shekhirin
added
A-db
| tx_count: if tx_count.end == tx_count.start { | ||
| tx_count.start..tx_count.start + 1 | ||
| } else { | ||
| tx_count | ||
| }, |
There was a problem hiding this comment.
nit: you can accept impl RangeBounds<u8>, and convert into Range here, so you can explicitly pass TEST_TRANSACTIONS_COUNT..=TEST_TRANSACTIONS_COUNT
There was a problem hiding this comment.
I'm not sure if this solves the problem... Indeed this if/else is there for the case where BlockRangeParams is default (for about half of the tests) and so the range is 0..0 which is not accepted by the random_block_range method which requires at least 0..1 (which was hardcoded before). That's why I did this trick, I think it's enough right?
There was a problem hiding this comment.
if you pass 0..=0 to this method, it should get converted to 0..1 which is basically the same as it was before, but more explicit
There was a problem hiding this comment.
Just fixed, let me know if this is what you had in mind here
No problem, always a pleasure to learn and discuss some tricks :) |
Should close #10339