-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(txpool): implement ensure_max_init_code_size() #1062
chore(txpool): implement ensure_max_init_code_size() #1062
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1062 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 313 313
Lines 34108 34140 +32
=======================================
+ Hits 25551 25576 +25
- Misses 8557 8564 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol nit, otherwise lgtm
fn ensure_max_init_code_size( | ||
&self, | ||
transaction: Self::Transaction, | ||
max_init_code_size: usize, | ||
) -> Result<(), PoolError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems ok for now, we'll figure out the right ergonomics later
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Closes #924
I'm not much sure whether it could close #924. I'll be really appreciate to point out me if I misunderstood the issue.