Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): improve debug_traceBlock performance #11069

Closed
wants to merge 3 commits into from
Closed

chore(rpc): improve debug_traceBlock performance #11069

wants to merge 3 commits into from

Conversation

JosepBove
Copy link
Contributor

Implements #11066

@JosepBove
Copy link
Contributor Author

First approach done, ready for review & feedback

mattsse
mattsse reviewed Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is slightly more complex, and requires a different approach, maybe like an Optional Inspector as argument and the trace_transaction also returns the inspector again

crates/rpc/rpc/src/debug.rs
@@ -332,7 +341,7 @@ where
Ok(frame.into())
})
.await?;
return Ok(frame)
return Ok(frame);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please undo these, makes it harder to review, idk why they keep reappearing...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you run cargo fmt and not cargo +nightly fmt...doom

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie, will update them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the approach does modifying the trace_transaction function to accept an optional inspector and return it along with the result and then modify trace_block function to use it sound good?

@joshieDo joshieDo added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Sep 24, 2024
@JosepBove JosepBove closed this by deleting the head repository Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JosepBove @mattsse @emhane @joshieDo