feat: add execute_with_witness #11074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
changed the title
mattsse
requested review from
Rjected,
fgimenez,
emhane and
rakita
as code owners
Rjected
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #10974
needs #11122 for rpc integration
the downside of this is, that this bakes in evm internals in executor API, but since the executor is already restricted to revm via
Databasethis should be okay.I still think there's a better approach re executor design, but this should unblock things for now, we can do smth similar for the streaming executor and then tackle abstraction debt as followup.
and this feature makes #11122 easier