Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pop() from flat tracer #11152

Closed
wants to merge 24 commits into from

Conversation

0xkrane
Copy link
Contributor

@0xkrane 0xkrane commented Sep 24, 2024

Follows #11114 and alloy-rs/alloy#1343 and needs an alloy dep bump

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending alloy release

@mattsse mattsse added S-blocked This cannot more forward until something else changes A-rpc Related to the RPC implementation labels Sep 24, 2024
@0xkrane 0xkrane marked this pull request as ready for review September 24, 2024 10:55
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx,
we can only do this with a lot more alloy related changes, so I'm closing this one

@mattsse mattsse closed this Sep 30, 2024
@0xkrane
Copy link
Contributor Author

0xkrane commented Oct 1, 2024

can help with some alloy related changes if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation S-blocked This cannot more forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants