-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): fix ImportReceiptsOp
#11216
Conversation
ImportReceiptsOp
for op-mainnet
ImportReceiptsOp
This reverts commit 01bccc2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -221,23 +199,54 @@ where | |||
// this ensures the execution outcome and static file producer start at block 1 | |||
first_block = 1; | |||
} | |||
highest_block_receipts = first_block + receipts.len() as u64 - 1; | |||
|
|||
// RLP file may have too many blocks. We ignore the excess, but warn the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when would this happen?
if the file has more blocks than the bedrock transition block? or duplicated blocks?
There seems to exist an extra block 105235064
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the file has more blocks than the bedrock transition block?
yes, may have been an user error when exporting the rlp data from the op-geth on defining the range of block data to export
or duplicated blocks?
also seems to be happening here with block 1 at the end of the set. but may just be some EOF wrap issue of the decoder, didnt look.
closes #10580
bedrock-blocks.rlp
or the decoder(didn't look) issues:1
is repeated and out of place - skipped105235064
- now we stop once we hit transactions block heightExecutionStageCheckpoint
to the highest block, otherwise an unwind of the receipts will be attempted on aRW
environment.Tested on commit 2995031
Tested with: