-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eip4844): add EIP4844
to the TxType
enum
#3953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol nit
/// Shard Blob Transactions - EIP-4844 | ||
EIP4844 = 3_isize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do this already
because does not conflict with the existing database
any objections @joshieDo ?
Codecov Report
... and 26 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending @joshieDo
apart from the CI error, it looks good to me with a but: We will have to break the database in the future, if we want to add new transaction types, because we are only using 2 bits to identify it currently |
gotcha, @joshieDo mind opening a PR with some docs for this? just so that we forget the next time we touch this |
Should solve #3952.