Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eip4844): add EIP4844 to the TxType enum #3953

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

tcoratger
Copy link
Contributor

Should solve #3952.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit

crates/rpc/rpc-types/src/eth/transaction/mod.rs Outdated Show resolved Hide resolved
Comment on lines +30 to +31
/// Shard Blob Transactions - EIP-4844
EIP4844 = 3_isize,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do this already

because does not conflict with the existing database

any objections @joshieDo ?

@mattsse mattsse added C-enhancement New feature or request E-cancun Related to the Cancun network upgrade labels Jul 27, 2023
@mattsse mattsse linked an issue Jul 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3953 (7630a31) into main (f98b152) will decrease coverage by 0.11%.
Report is 9 commits behind head on main.
The diff coverage is 90.90%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-types/src/eth/transaction/mod.rs 44.80% <ø> (ø)
crates/primitives/src/transaction/tx_type.rs 69.69% <75.00%> (-0.31%) ⬇️
crates/primitives/src/receipt.rs 83.39% <100.00%> (+0.39%) ⬆️

... and 26 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.36% <0.00%> (+0.79%) ⬆️
unit-tests 64.43% <90.90%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.16% <ø> (-0.02%) ⬇️
blockchain tree 83.04% <ø> (ø)
pipeline 89.82% <ø> (ø)
storage (db) 74.30% <ø> (+0.01%) ⬆️
trie 94.70% <ø> (ø)
txpool 45.74% <ø> (-0.26%) ⬇️
networking 77.62% <ø> (-0.08%) ⬇️
rpc 58.37% <ø> (-0.37%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 87.80% <90.90%> (-0.12%) ⬇️

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @joshieDo

@joshieDo
Copy link
Collaborator

apart from the CI error, it looks good to me with a but: We will have to break the database in the future, if we want to add new transaction types, because we are only using 2 bits to identify it currently

@mattsse
Copy link
Collaborator

mattsse commented Jul 27, 2023

gotcha,

@joshieDo mind opening a PR with some docs for this? just so that we forget the next time we touch this

@mattsse mattsse added this pull request to the merge queue Jul 27, 2023
Merged via the queue into paradigmxyz:main with commit 369b9a7 Jul 27, 2023
23 checks passed
@tcoratger tcoratger deleted the 4844-enum branch July 27, 2023 21:11
@tcoratger tcoratger mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request E-cancun Related to the Cancun network upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(eip4844): add EIP4844 to the TxType enum
3 participants