Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(primitives): sealed block senders check #6822

Merged
merged 3 commits into from
Feb 27, 2024
Merged

fix(primitives): sealed block senders check #6822

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c60dd2
fix sealed block
rkrasiuk Feb 27, 2024
4f2bbde
same fix for BlockWithSenders
rkrasiuk Feb 27, 2024
8260243
add test
rkrasiuk Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/primitives/src/block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ pub struct BlockWithSenders {
impl BlockWithSenders {
/// New block with senders. Return none if len of tx and senders does not match
pub fn new(block: Block, senders: Vec<Address>) -> Option<Self> {
(!block.body.len() != senders.len()).then_some(Self { block, senders })
(block.body.len() == senders.len()).then_some(Self { block, senders })
}

/// Seal the block with a known hash.
Expand Down Expand Up @@ -387,7 +387,7 @@ pub struct SealedBlockWithSenders {
impl SealedBlockWithSenders {
/// New sealed block with sender. Return none if len of tx and senders does not match
pub fn new(block: SealedBlock, senders: Vec<Address>) -> Option<Self> {
(!block.body.len() != senders.len()).then_some(Self { block, senders })
(block.body.len() == senders.len()).then_some(Self { block, senders })
}

/// Split Structure to its components
Expand Down
Loading