Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable default feature for reth-db in workspace #8476

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented May 29, 2024

reth-db has a feature for all things libmdbx, some crates currently rely on the traits defined in this crate

does not compile blocked by #8477

blocked by #8512

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label May 29, 2024
@mattsse mattsse marked this pull request as ready for review May 30, 2024 21:17
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain and removed S-blocked This cannot more forward until something else changes labels May 30, 2024
@mattsse mattsse added the S-blocked This cannot more forward until something else changes label May 30, 2024
@mattsse mattsse removed the S-blocked This cannot more forward until something else changes label Jun 5, 2024
@mattsse mattsse added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 01fd9b3 Jun 5, 2024
29 checks passed
@mattsse mattsse deleted the matt/start-disabling-default-features branch June 5, 2024 09:27
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants