Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs to StaticFileProvider::check_consistency #8591

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jun 4, 2024

Add logs for when an unwind target is set, alongside useful information that can be used to debug.

Open to bump it down to debug! in the future, but for now it would be more useful to have it as info imo.

@joshieDo joshieDo added A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files labels Jun 4, 2024
@joshieDo joshieDo requested a review from mattsse June 4, 2024 13:17
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from Discord:

they're only supposed to print when something goes extremely wrong
since recovery for unwind should be only for data corruption (if no bug)

not a fan of info level here, but should be fine because it's a rare case. LGTM.

@joshieDo joshieDo added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 8d95a75 Jun 4, 2024
31 checks passed
@joshieDo joshieDo deleted the joshie/consistency-logs branch June 4, 2024 14:01
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants