Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move RPC cache constants and type #8597

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat: move RPC cache constants and type #8597

merged 2 commits into from
Jun 4, 2024

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Jun 4, 2024

Closes #8588

onbjerg
onbjerg approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Jun 4, 2024
mattsse
mattsse requested changes Jun 4, 2024
View reviewed changes
crates/rpc/rpc-server-types/src/args/rpc_state_cache.rs Outdated
DEFAULT_BLOCK_CACHE_MAX_LEN, DEFAULT_CONCURRENT_DB_REQUESTS, DEFAULT_ENV_CACHE_MAX_LEN,
DEFAULT_RECEIPT_CACHE_MAX_LEN,
};
use clap::Args;

/// Parameters to configure RPC state cache.
#[derive(Debug, Clone, Args, PartialEq, Eq)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this I want to keep in node-core because it's an Args type

mattsse
mattsse approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I think next step is investigating, whether we can extract the node-core/cli/config/ traits.

a few solutions are possible here
a) move them to node-builder
b) move all of them to a separate crate under CLI
c) move RethRpcConfig to rpc-builder

perhaps option c) is the most viable solution

@mattsse mattsse added this pull request to the merge queue Jun 4, 2024
Merged via the queue into paradigmxyz:main with commit e1f39bd Jun 4, 2024
29 checks passed
@leruaa leruaa mentioned this pull request Jun 4, 2024
Closed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@leruaa @mw2000
feat: move RPC cache constants and type (paradigmxyz#8597)
b643417
@leruaa leruaa deleted the move_rpc_cache_constants branch July 12, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move RPC cache constants and types to reth-rpc-server-types
3 participants
@leruaa @onbjerg @mattsse