fix: check for empty tx root in BlockTransactions::Uncle match #8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
mattsse
approved these changes
Jun 4, 2024
| @@ -36,7 +36,13 @@ impl TryFrom<alloy_rpc_types::Block> for Block { | |||
| .collect(), | |||
| alloy_rpc_types::BlockTransactions::Hashes(_) | | |||
| alloy_rpc_types::BlockTransactions::Uncle => { | |||
| return Err(ConversionError::MissingFullTransactions) | |||
| // alloy deserializes empty blocks into `BlockTransactions::Uncle`, if the tx | |||
There was a problem hiding this comment.
I don't think this note is correct, [] would be Hashes because it's the first variant
There was a problem hiding this comment.
right, thought it was uncle because of default, but it's not
Rjected
force-pushed
the
dan/fix-alloy-deser-empty
branch
from
3f8a678
to
64b86ce
Compare
Rjected
force-pushed
the
dan/fix-alloy-deser-empty
branch
from
64b86ce
to
a78b7e8
Compare
|
clippy issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things in alloy conversions: