chore: update CODEOWNERS for new crate structure #8601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
reviewed
Jun 4, 2024
CODEOWNERS
Outdated
| crates/stages-api/ @onbjerg @rkrasiuk @shekhirin | ||
| crates/static-file @joshieDo @shekhirin | ||
| crates/static-file/ @joshieDo @shekhirin | ||
| crates/static-file-types/ @joshieDo @shekhirin | ||
| crates/storage/ @rakita @joshieDo @shekhirin |
There was a problem hiding this comment.
think we need to unpack this folder at some point, it contains so much code by diff authors i think it makes sense to be granular
There was a problem hiding this comment.
any suggestions on owners for each subfolder?
There was a problem hiding this comment.
the owner set will be roughly the same, but i think it makes sense to be granular still, esp when/if these are refactored, so i think
crates/storage/codecs @joshieDo
crates/storage/db @joshieDo @rakita
crates/storage/db-api @joshieDo @rakita # think these were written primarily by joshie/dragan?
crates/storage/libmdbx-rs @rakita # think dragan has primarily been maintaining this
crates/storage/nippy-jar @joshieDo @shekhirin
crates/storage/provider @rakita @joshieDo @shekhirin storage-api/errors/db-common i have no idea
There was a problem hiding this comment.
no idea why formatting is so bad, they are aligned when editing the comment
There was a problem hiding this comment.
copied this, tried to fill all the subfolders for storage
mattsse
approved these changes
Jun 5, 2024
rkrasiuk
approved these changes
Jun 5, 2024
Rjected
force-pushed
the
dan/add-codeowners-new-structure
branch
from
c5b4fe6
to
99441c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates CODEOWNERS for the current folder structure we have, removed some things that no longer exist, and tried to assign people to paths
If anyone wants on / off one of these folders, please comment!
I'm not sure who to put on
fs-util, so I would like feedback on that