feat: move calculate_intrinsic_gas_after_merge to tx pool

[kamuik16]

Closes #8899

[kamuik16]

revm is not used in reth-primitives now, so giving a warning of unused crates but some features use it as a dep and removing revm from features seems to break some things. used allow for now to pass ci.

[DaniPopes]

What's breaking ? Ideally we want to remove revm from here, is it maybe usage in tests?

[kamuik16]

What's breaking ? Ideally we want to remove revm from here, is it maybe usage in tests?

I tried to do it in 82b569d. Checkout its CI failures.

By mistake closed the PR. sorry for that.

[DaniPopes]

Oh, I think you just need to propagate the optimism feature to revm-primitives instead of revm

reth/crates/primitives/Cargo.toml

Lines 112 to 117 in c008a1f

	optimism = [
	"reth-chainspec/optimism",
	"reth-codecs/optimism",
	"reth-ethereum-forks/optimism",
	"revm/optimism",
	]

[kamuik16]

Oh, I think you just need to propagate the optimism feature to revm-primitives instead of revm

reth/crates/primitives/Cargo.toml

Lines 112 to 117 in c008a1f

	optimism = [
	"reth-chainspec/optimism",
	"reth-codecs/optimism",
	"reth-ethereum-forks/optimism",
	"revm/optimism",
	]

Got a different error now.

[onbjerg]

revm is not used in reth-primitives now, so giving a warning of unused crates but some features use it as a dep and removing revm from features seems to break some things. used allow for now to pass ci.

mark it as optional, and then use dep:revm in the features that use it

[kamuik16]

revm is not used in reth-primitives now, so giving a warning of unused crates but some features use it as a dep and removing revm from features seems to break some things. used allow for now to pass ci.

mark it as optional, and then use dep:revm in the features that use it

still giving me a warning that revm is an unused crate, i tried this earlier too.