Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't drop the TaskManager #8941

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: don't drop the TaskManager #8941

merged 1 commit into from
Jun 18, 2024

Conversation

prestwich
Copy link
Collaborator

Prevents the ExExContext TaskExecutor from starting in the shutdown state

@prestwich prestwich self-assigned this Jun 18, 2024
shekhirin
shekhirin approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you!

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test A-exex Execution Extensions labels Jun 18, 2024
@shekhirin shekhirin added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit da0004e Jun 18, 2024
31 checks passed
@shekhirin shekhirin deleted the prestwich/own-taskmanager branch June 18, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

@prestwich prestwich

Labels
A-exex Execution Extensions C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @shekhirin