Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs db #8979

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Update docs db #8979

merged 3 commits into from
Jun 20, 2024

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jun 20, 2024

the link and code in docs/crates/db.md is staled, update them

@9547 9547 requested a review from gakonst as a code owner June 20, 2024 09:18
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

should we keep maintaining this @shekhirin ?

this will break again -.-

@shekhirin shekhirin added C-docs An addition or correction to our documentation A-db Related to the database labels Jun 20, 2024
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's quite difficult to maintain, but I don't think we should remove this doc altogether. Thank you for doing this work, LGTM :)

@mattsse mattsse added this pull request to the merge queue Jun 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@mattsse mattsse added this pull request to the merge queue Jun 20, 2024
Merged via the queue into paradigmxyz:main with commit e90b526 Jun 20, 2024
31 checks passed
@9547 9547 deleted the update-docs-db branch June 21, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants