Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(no_std): fixed no_std compiler errors in reth-primitives-traits #9572

Merged
merged 6 commits into from
Jul 17, 2024
Merged

chore(no_std): fixed no_std compiler errors in reth-primitives-traits #9572

merged 6 commits into from
Jul 17, 2024

Conversation

martinezjorge
Copy link
Contributor

Helps progress #9478

@martinezjorge martinezjorge changed the title chore(no_std): fixed no_std compiler errors in reth-primitive-traits crate chore(no_std): fixed no_std compiler errors in reth-primitives-traits Jul 17, 2024
mattsse
mattsse requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what we also need is setting this crate's default-features = false on the workspace level cargo.toml

crates/primitives-traits/src/constants/gas_units.rs Outdated Show resolved Hide resolved
crates/primitives-traits/src/lib.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 17, 2024
@mattsse mattsse requested a review from gakonst as a code owner July 17, 2024 16:44
@mattsse mattsse force-pushed the fix-no-std-compiler-errors-in-primitive-traits branch 2 times, most recently from 7c105bd to fbeaba1 Compare July 17, 2024 16:45
mattsse
mattsse approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

I did some finishing touchups because this pr is required by something I'm working on.

@mattsse mattsse force-pushed the fix-no-std-compiler-errors-in-primitive-traits branch 2 times, most recently from 4a004f5 to f45bddd Compare July 17, 2024 16:51
@mattsse mattsse enabled auto-merge July 17, 2024 16:53
@mattsse mattsse force-pushed the fix-no-std-compiler-errors-in-primitive-traits branch from f45bddd to e461ec5 Compare July 17, 2024 16:56
@mattsse mattsse requested a review from fgimenez as a code owner July 17, 2024 17:08
@mattsse mattsse added this pull request to the merge queue Jul 17, 2024
Merged via the queue into paradigmxyz:main with commit 8417473 Jul 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinezjorge @mattsse