Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parity selfdestruct traces are inserted out of order #162

Closed
mattsse opened this issue Jul 12, 2024 · 0 comments · Fixed by #170
Closed

parity selfdestruct traces are inserted out of order #162

mattsse opened this issue Jul 12, 2024 · 0 comments · Fixed by #170

Comments

@mattsse
Copy link
Contributor

mattsse commented Jul 12, 2024

paradigmxyz/reth#9142

we don't record selfdestructs as individual trace nodes instead the node can have a selfdestruct state.

we compute the traceAddress correctly

           "traceAddress": [
                  2
              ]

but they get inserted incorrectly, right after the top-level call:

https://github.com/paradigmxyz/evm-inspectors/blob/b9850ffe4d67aadc46cba5e3798bee459a01a560/src/tracing/builder/parity.rs#L238-L256

TODO

  • insert selfdestruct after the last subtrace
mattsse pushed a commit that referenced this issue Jul 23, 2024
The `suicide`/`selfdestruct` trace should not be immediately after the
parent trace but after all of the parent's subtraces.

This can be fixed by ordering the `traces` using the attribute
`trace_address` inside.

closes #162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant