Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline text not preserved when using "maxWidth" property #2942

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

listopadiya
Copy link
Contributor

There was a problem when using multiline text and maxWidth text property simultameously, maxWidth was kind of rewriting existing text line splitting. It could be seen with multiline text inside table cell (#2891) or just with ordinary text like this:

doc.setFontSize(16);
doc.text("This is first line.\nThis is next line.", 20, 20, {"maxWidth": 25});
doc.text(["This is first line.","This is next line."], 20, 60, {"maxWidth": 25});

With this PR lines of text defined by user are preserved when putting width restriction on them. It works for both multiline-as-an-array and multiline-as-formatted-with-linebreak-symbols texts. Also cell line height calculation was fixed, so that it works for both variants described above.

There is String Splitting example in live demo, it works correctly, but looks like it uses splitTextToSize method directly.

Basic checks done:

  • different combinations checked manually in Live Demo
  • two problem-specific unit tests are added
  • npm run test-local pass except one test (which is not passing in master branch for me as well, so probably it is my local browser-related problem or whatever)

@HackbrettXXX HackbrettXXX merged commit 704f5a9 into parallax:master Oct 5, 2020
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants