Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement justifying for unicode fonts #3285

Merged
merged 8 commits into from
Feb 11, 2022

Conversation

owenl131
Copy link
Contributor

@owenl131 owenl131 commented Oct 2, 2021

Resolves #3261

When processing justified text, it checks if it is using a unicode font. If so, it processes the spaces properly to make the text justified.

@owenl131
Copy link
Contributor Author

owenl131 commented Oct 3, 2021

It's ready for review. Thanks!

Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good.

@TD-DO
Copy link

TD-DO commented Feb 9, 2022

Can someone please merge this into master? I'd really love to be able to use this.

@HackbrettXXX HackbrettXXX merged commit 2d9a919 into parallax:master Feb 11, 2022
@HackbrettXXX
Copy link
Collaborator

Thanks for the reminder. I've merged it now. I hope I can release it soon if I find the time.

@TD-DO
Copy link

TD-DO commented Feb 11, 2022

Thanks!

@mahgoh
Copy link

mahgoh commented Nov 29, 2022

Thanks for the reminder. I've merged it now. I hope I can release it soon if I find the time.

Really appreciate the work done here. Any chance the release will happen soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Justify text with any custom font does not work
4 participants