Change socket location and add checks #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
approved these changes
Jun 29, 2020
| /// Checks if the socket is inside a folder with correct owners and permissions to make sure it | ||
| /// is from the Parsec service. | ||
| #[cfg(not(testing))] | ||
| fn secure_parsec_socket_folder(&self) -> Result<()> { |
There was a problem hiding this comment.
Do you think it's worth making this check conditional (as in, not only on testing, but also on another feature) in case an admin can't/doesn't want to follow these directives 100%?
There was a problem hiding this comment.
Yes, you are probably right, admins could use a client that does not use this security feature. Will add another feature.
ionut-arm
reviewed
Jun 30, 2020
Cargo.toml
Outdated
|
|
||
| [dev-dependencies] | ||
| mockstream = "0.0.3" | ||
|
|
||
| [features] | ||
| testing = ["parsec-interface/testing"] | ||
| testing = ["parsec-interface/testing", "no-security-check"] | ||
| no-security-check = [] |
There was a problem hiding this comment.
I think the name is a bit extreme, maybe something like no-fs-permission-check - a bit lengthy but closer in meaning. Also, I guess it should be documented somewhere (both in Readme and in docs.rs?)
There was a problem hiding this comment.
Modified the name and added it to the README.
Adds a check for the directory containing the socket. It must be owned by the parsec user and parsec-clients group and be 750. This check is disabled for testing. Signed-off-by: Hugues de Valon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for the directory containing the socket. It must be owned
by the parsec user and parsec-clients group and be 750. This check is
disabled for testing.
Signed-off-by: Hugues de Valon [email protected]