Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JWT-SVID authentication method #61

Merged
merged 3 commits into from
Nov 26, 2020
Merged

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Nov 6, 2020

Using this method, the client will fetch its JWT-SVID and send it in the
authentication field.
The socket endpoint is found through the SPIFFE_ENDPOINT_SOCKET
environment variable.

Using this method, the client will fetch its JWT-SVID and send it in the
authentication field.
The socket endpoint is found through the SPIFFE_ENDPOINT_SOCKET
environment variable.

Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev hug-dev marked this pull request as draft November 6, 2020 16:59
@hug-dev
Copy link
Member Author

hug-dev commented Nov 6, 2020

This won't work until the changes are pushed in some rust-spiffe repository 🥇

@hug-dev hug-dev linked an issue Nov 6, 2020 that may be closed by this pull request
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good overall, just a few minor comments

src/error.rs Outdated Show resolved Hide resolved
src/auth.rs Show resolved Hide resolved
src/auth.rs Outdated Show resolved Hide resolved
Signed-off-by: Hugues de Valon <[email protected]>
@hug-dev
Copy link
Member Author

hug-dev commented Nov 9, 2020

Addressed comment in a new commit for easier review.

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/core/testing/core_tests.rs Show resolved Hide resolved
@hug-dev
Copy link
Member Author

hug-dev commented Nov 23, 2020

Used this branch to make it compile now. Added a feature as was agreed in the community meeting.

@hug-dev hug-dev marked this pull request as ready for review November 23, 2020 14:58
@hug-dev hug-dev force-pushed the spiffe branch 2 times, most recently from 225810f to 7fa0a9a Compare November 23, 2020 16:55
Also add a feature for the SPIFFE authenticator, activated by default.

Signed-off-by: Hugues de Valon <[email protected]>
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/auth.rs Show resolved Hide resolved
tests/ci.sh Show resolved Hide resolved
@hug-dev hug-dev merged commit 3c78e3e into parallaxsecond:master Nov 26, 2020
@hug-dev hug-dev deleted the spiffe branch November 26, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a JWT-SVID authentication data
2 participants