Make separate constructors for RO/RW sessions #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous constructor took a boolean argument which made it difficult to understand what the user code would be doing. That constructor is now two separate functions, one for RO sessions, one for RW sessions. The `_no_callback` part of the method name was also removed and added to the documentation instead. Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
requested review from
wiktor-k,
mike-boquard,
mohamedasaker-arm and
gowthamsk-arm
ximon18
reviewed
Sep 5, 2022
cryptoki/tests/basic.rs
Outdated
| ro_session.login(UserType::User, Some(USER_PIN))?; | ||
|
|
||
| // generate a key pair | ||
| // This should NOT work using the Read/Write session |
There was a problem hiding this comment.
I think you meant "Read-Only" in this comment rather than "Read/Write".
Should the same change also be made to |
ximon18
approved these changes
Sep 5, 2022
I was wondering, but I felt more comfortable with a more verbose (but accurate) name for an internal function, though maybe consistency is more important 🤔 Will change |
Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
force-pushed
the
ro-rw-sessions
branch
from
b54085f
to
38d5538
Compare
ximon18
approved these changes
Sep 6, 2022
wiktor-k
approved these changes
Sep 7, 2022
ionut-arm
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous constructor took a boolean argument which made it difficult
to understand what the user code would be doing. That constructor is now
two separate functions, one for RO sessions, one for RW sessions. The
_no_callbackpart of the method name was also removed and added to thedocumentation instead.
cc @ximon18