20240308 mechanisms #203
Merged
20240308 mechanisms #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
🤔 Well, generally when adding new mechanisms we ask for tests cases showing that they work against SoftHSM but the majority of this change is adding stuff that already exists and for the rest I'm not sure there's much value in testing HMAC values...
Please squash your commits and add a sign-off and for me it's good to go. 👍
Firstyear
force-pushed
the
20240308-mechanisms
branch
from
6909a2f
to
8731fdc
Compare
Signed-off-by: William Brown <[email protected]>
Firstyear
force-pushed
the
20240308-mechanisms
branch
from
8731fdc
to
c4f8952
Compare
|
Should be there now, I think it just needed a rebase on main |
hug-dev
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing this library with the tpm2_pkcs11 provided I noticed a number of mechanisms that were unable to be displayed.