Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for getting attribute info - #42 #48

Merged

Conversation

mike-boquard
Copy link
Collaborator

  • Updated comment for get_attribute_info
  • Added get_attribute_info_map
  • Added get_single_attribute_info
  • Added Hash derivation for AttributeType

Signed-off-by: Michael J Boquard [email protected]

- Updated comment for `get_attribute_info`
- Added `get_attribute_info_map`
- Added `get_single_attribute_info`
- Added `Hash` derivation for `AttributeType`

Signed-off-by: Michael J Boquard <[email protected]>
@mike-boquard mike-boquard changed the title Updates for getting attribute info Updates for getting attribute info - #42 Sep 23, 2021
@hug-dev hug-dev self-requested a review September 23, 2021 16:53
@hug-dev hug-dev added the enhancement New feature or request label Sep 23, 2021
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few more ideas...

cryptoki/src/functions/object_management.rs Outdated Show resolved Hide resolved
cryptoki/src/functions/object_management.rs Show resolved Hide resolved
cryptoki/src/functions/object_management.rs Outdated Show resolved Hide resolved
- Updated `AttributeInfo` to include `Sensitive` and `TypeInvalid` variants
- Removed `Unavailable` variant from `AttributeInfo`
- Updated `get_attribute_info` to step through each attribute
- Removed `get_single_attribute_info`

Signed-off-by: Michael J Boquard <[email protected]>
@mike-boquard mike-boquard force-pushed the implement-attribute-info-updates-#42 branch from 4dd3fe6 to 89e015c Compare September 24, 2021 20:28
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

cryptoki/src/functions/object_management.rs Outdated Show resolved Hide resolved
cryptoki/src/functions/object_management.rs Show resolved Hide resolved
cryptoki/src/types/object.rs Show resolved Hide resolved
- Updated function comments
- Fixed some warnings generated by the docs

Signed-off-by: Michael J Boquard <[email protected]>
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hug-dev hug-dev merged commit 2f51a2f into parallaxsecond:devel Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants