-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info flags refactor #68
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
3241c1b
Add a missing flag value used by TokenInfo
vkkoskie 5951c48
Add two missing MechanismInfo flags
vkkoskie 59fc60d
Remove unused SlotInfo traits
vkkoskie 0fcd611
Convert SlotInfo contents once
vkkoskie 8e5db26
Replace SlotInfo::new() with From impl
vkkoskie 937d904
Merge get_all_slots and get_all_slots_with_token
vkkoskie e4436e2
Fix race condition in get_slots
vkkoskie 10928a1
Expose SlotInfo flags individually
vkkoskie 26925ab
Privatize SlotFlags; remove usused methods
vkkoskie 6e6a2e9
Reimplement generic flags, then use in SlotInfo
vkkoskie 9956187
Update SlotInfo docs
vkkoskie a573088
Refactor TokenInfo Flags
vkkoskie 54cb98c
Hide conversions from sys crate in public docs
vkkoskie bee02b9
Refactor MechanismInfo Flags
vkkoskie 0ae3adb
Move info types
vkkoskie aab33b7
Tidy info/flag docs
vkkoskie 5bb40c6
Add Version constructor
vkkoskie 88134f0
Add unit tests for info+flags debug content
vkkoskie de46362
Remove Display trait from Flag types
vkkoskie 1b7f520
Tidy imports
vkkoskie 0650deb
Remove some stray comment errors
vkkoskie 5dfddf8
Add UtcTime implementation
vkkoskie 46a2691
Make UtcTime conversion fallible
vkkoskie 261d934
Refactor SessionInfo
vkkoskie 67e7589
Replace SessionFlags with bool to open session
vkkoskie e221cf6
Remove unused SessionFlags type
vkkoskie 992bfbf
Refactor SessionState
vkkoskie d4917a8
Remove InitializeFlags
vkkoskie 1cbad05
Replace Display for UtcTime with named function
vkkoskie 7ffa711
Replace custom CkFlags impl with bitflags crate
vkkoskie 6dacb62
Refactor general Info struct
vkkoskie f18c73e
Replace nested Options with Limit newtype
vkkoskie 40810ee
Add comment to explain test condition
vkkoskie 7a0ad30
Move Option variants to single scope
vkkoskie aae8de0
Reduce visibility of Version constructor
vkkoskie b15eecd
Minor fix/enhance of a few comments
vkkoskie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I'm not really too much into having boolean parameters since it's not obvious what
open_session_no_callback(..., true)
does (an enum withREAD_WRITE
orREAD_ONLY
would be more... readable) but on the other hand it's commonly used and the IDE can offer hints.Or even export two functions:
open_readonly_session_no_callback
oropen_readwrite_session_no_callback
...Btw very nice to see you providing explicit reasoning in the commit message for SessionFlags refactor: 67e7589 👏 thanks!