Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve open issues #84

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Solve open issues #84

merged 5 commits into from
Mar 2, 2022

Conversation

ionut-arm
Copy link
Member

Fixing a few of the open issues:

@ionut-arm
Add is_fn_supported method to Context (parallaxsecond#78)
efc79d4 
Adding a way to check if a specific PKCS11 function is supported by the
given `Context`

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm
Allow checking for initialization status
61e5ead 
The `Pkcs11` struct is enhanced to store a flag identifying whether the
library has been initialized or not. This flag can then be used to
signal re-initialization attempts and to simply inform users of the
status.

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm added bug Something isn't working enhancement New feature or request code health Issues concerning overall code quality, safety and best practice labels Feb 9, 2022
@ionut-arm ionut-arm self-assigned this Feb 9, 2022
wiktor-k
wiktor-k approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok 👍

cryptoki/src/types.rs Outdated Show resolved Hide resolved
cryptoki/src/context/general_purpose.rs Show resolved Hide resolved
@ionut-arm
Fix Date attribute parsing (parallaxsecond#74)
a190b02 
The Date attribute can be returned as empty (i.e., parameter length is 0),
however our parsing did not consider this option.
A test is also added to ensure that any regressions are caught.

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm
Copy link
Member Author

@ximon18 - could you please have a look and confirm that this aligns with your needs for Krill?

@ximon18
Copy link
Contributor

ximon18 commented Feb 14, 2022

Thanks, I'll take a look tomorrow!

@ximon18
Copy link
Contributor

ximon18 commented Feb 15, 2022 •
edited
Loading

@ximon18 - could you please have a look and confirm that this aligns with your needs for Krill?

@ionut-arm: LGTM!

anta5010
anta5010 reviewed Mar 1, 2022
View reviewed changes
cryptoki/src/object.rs Outdated Show resolved Hide resolved
@ionut-arm
Fix StartDate conversion
904d88f 
Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm merged commit 6c82a57 into parallaxsecond:main Mar 2, 2022
@ionut-arm ionut-arm deleted the krill-req branch March 2, 2022 15:00
@ximon18
Copy link
Contributor

ximon18 commented Aug 4, 2022

@ionut-arm : Am I right in thinking that these new capabilities are still not available in a released version of the cryptoki crate?

@ionut-arm
Copy link
Member Author

@ionut-arm : Am I right in thinking that these new capabilities are still not available in a released version of the cryptoki crate?

Ah, no, sorry, what I meant is that after I release it'll be possible to update, but I haven't published the new version to crates.io.

And yes, I do have to update the changelog too... 😬

@ximon18
Copy link
Contributor

ximon18 commented Aug 19, 2022

So, @ionut-arm, is there any idea when a new release of cryptoki including these improvements will be made?

@ionut-arm
Copy link
Member Author

Hey @ximon18 ! Sure, I can prioritise a release of this, though it will be quite a change to some parts of the API (just to make sure you're aware 😄 ).

Also, I just realised that when I answered the question above I was in zombie mode and thought I was answering the cryptoki-sys convo, apologies.

@ximon18
Copy link
Contributor

ximon18 commented Aug 23, 2022

Thanks @ionut-arm. It's not per se that it is urgent, more a chicken and egg situation that there are some new things I requested that I could take advantage of, but not without there first being a release ;-)

@ximon18
Copy link
Contributor

ximon18 commented Aug 23, 2022

Hey @ximon18 ! Sure, I can prioritise a release of this, though it will be quite a change to some parts of the API (just to make sure you're aware smile ).

@ionut-arm: I just did a test compile against current main of cryptoki which worked fine, in our application I only had to change the call to open_session() (and raised #97 as a possible improvement to consider before you release).

This was referenced Aug 24, 2022
Open
Open
@ionut-arm ionut-arm added the breaking-change Marker for PRs that break the interface of one of the crates label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktor-k wiktor-k wiktor-k approved these changes

@anta5010 anta5010 anta5010 approved these changes

@mike-boquard mike-boquard Awaiting requested review from mike-boquard

@hug-dev hug-dev Awaiting requested review from hug-dev

@paulhowardarm paulhowardarm Awaiting requested review from paulhowardarm

Assignees

@ionut-arm ionut-arm

Labels
breaking-change Marker for PRs that break the interface of one of the crates bug Something isn't working code health Issues concerning overall code quality, safety and best practice enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to test for supported functions? Add is_initialized() to Pkcs11 Segmentation fault on parsing Date
4 participants
@ionut-arm @ximon18 @wiktor-k @anta5010