-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve open issues #84
Conversation
Adding a way to check if a specific PKCS11 function is supported by the given `Context` Signed-off-by: Ionut Mihalcea <[email protected]>
The `Pkcs11` struct is enhanced to store a flag identifying whether the library has been initialized or not. This flag can then be used to signal re-initialization attempts and to simply inform users of the status. Signed-off-by: Ionut Mihalcea <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok 👍
The Date attribute can be returned as empty (i.e., parameter length is 0), however our parsing did not consider this option. A test is also added to ensure that any regressions are caught. Signed-off-by: Ionut Mihalcea <[email protected]>
@ximon18 - could you please have a look and confirm that this aligns with your needs for Krill? |
Thanks, I'll take a look tomorrow! |
Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm: LGTM! |
Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm : Am I right in thinking that these new capabilities are still not available in a released version of the |
Ah, no, sorry, what I meant is that after I release it'll be possible to update, but I haven't published the new version to crates.io. And yes, I do have to update the changelog too... 😬 |
So, @ionut-arm, is there any idea when a new release of cryptoki including these improvements will be made? |
Hey @ximon18 ! Sure, I can prioritise a release of this, though it will be quite a change to some parts of the API (just to make sure you're aware 😄 ). Also, I just realised that when I answered the question above I was in zombie mode and thought I was answering the |
Thanks @ionut-arm. It's not per se that it is urgent, more a chicken and egg situation that there are some new things I requested that I could take advantage of, but not without there first being a release ;-) |
@ionut-arm: I just did a test compile against current |
Fixing a few of the open issues:
Date
#74 - changing the way we handleDate
parsing to account for empty valuesis_initialized()
toPkcs11
#77 - add a method to check whether the context was initialized