session_management: Add ability to login with raw bytes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subject38
force-pushed
the
login_raw
branch
2 times, most recently
from
7518da0
to
a7d839d
Compare
Signed-off-by: seth <[email protected]>
hug-dev
approved these changes
May 2, 2022
ionut-arm
approved these changes
May 3, 2022
There was a problem hiding this comment.
Excellent, thank you very much for contributing this!
I had one question - do you have a "list" (or at least some examples) of PKCS11 implementations where this is needed, apart from the Safenet example from the PR you linked? This kind of edge case sounds like something we should be covering in Parsec, and it would be really good to have documentation as to which token implementations might need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this addition is identical to mheese/rust-pkcs11#8. Some dongle drivers are insane and allow you to use invalid strings as a PIN. As a result we need a way to pass in a raw slice of bytes.