Adds support for non pkg-config tpm2-tss installs. #477

Superhepper · 2023-12-09T22:07:06Z

This adds support for specifying an install path of tpm2-tss libraries and header files in order to make it possible to build crate without having to relay on pkg-config.

wiktor-k · 2023-12-10T12:00:43Z

Very interesting development!

By the way Github supports windows CI runners so maybe it would be useful to at least run cargo build there?

Superhepper · 2023-12-10T12:06:09Z

Yeah this is just a test. I would really like to be able run the tests before committing anything.

wiktor-k · 2024-03-29T14:15:26Z

Wow, that's great! Given that the simulator has ms in its name I guess this is just a matter of time. For the record I've also had slight "problems" with running integration tests on Windows: https://github.com/wiktor-k/ssh-agent-lib/pull/25/files#diff-b1a180c7db3d68d63c6a33ea491b590c09cca209c930eae52c1f6dae2b00768e

👋

ionut-arm

That's quite a complicated build file, I'm surprised something like it doesn't exist more generally..

Thanks for the patch!

ionut-arm · 2024-04-01T09:15:54Z

tss-esapi-sys/build.rs

+                        //See this issue: https://github.com/parallaxsecond/rust-cryptoki/issues/12
+                        .generate_comments(false)
+                        .blocklist_type("max_align_t")
+                        // Needed for windows


What was the issue here?

When you compile under windows ( I used msvc 2022) you get a lot of errors of structs that it some how thinks are needed but not available probably due to it importing "windows.h" or something. So I just blocked everything that caused an error.

I meant when you generate the bindings on a windows machine.

When you compile under windows ( I used msvc 2022) you get a lot of errors of structs that it some how thinks are needed but not available probably due to it importing "windows.h" or something.

I wonder if WIN32_LEAN_AND_MEAN would help here... (note that I'm no C/C++ dev so this may be wildly wrong)...

tss-esapi-sys/build.rs

- Adds support for specifying path to the tpm2-tss libraries and header files using the environment variable ```TPM2_TSS_PATH```. The specified path is expected to have the following layout: | -> <Specified path> | | -> include | | -> tss2 | | -> tss2_esys.h | | | -> lib | | -> tss2_esys.lib (or .so) Signed-off-by: Jesper Brynolf <[email protected]>

ionut-arm · 2024-04-06T20:22:44Z

tss-esapi-sys/build.rs

+            let min_version_req = VersionReq::parse(&min_version_req_str).unwrap_or_else(|e| {
+                panic!(
+                    "[Internal Error]: Failed to parse minimum tpm2-tss library version \
+                     requirement. Error: `{}`. Please report this.",


Love the "Please report this" bit, we should do it more.

tss-esapi-sys/build.rs

ionut-arm

👍🏻

wiktor-k · 2024-04-08T10:00:29Z

It looks good on a quick look. Is there a plan to add a windows target that at least builds it and checks that it doesn't regress?

I've seen people commenting on how to build it and such a CI config would be one place to point them... 🤔

Superhepper · 2024-04-08T11:18:39Z

@wiktor-k
I have it on my list of things I want to improve. But I have found no way of accomplishing it. So I am going to create a ticket for it and if some Windows savvy github actions enthusiast could take a look at it. It would be great.

When parallaxsecond#477 got merged it became possible to build using a path to the ```tpm2-tss``` installation instead of depending on ```pkg-config```. This made it possible to build under Windows. To further increase the support for the windows platform this commit moves the option for TBS TCTI that is being introduced in parallaxsecond#523 into a separate commit. This commit also updates the documentation regarding building using an installation folder. Co-author: Thomas Thomas Epperson <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>

When parallaxsecond#477 got merged it became possible to build using a path to the ```tpm2-tss``` installation instead of depending on ```pkg-config```. This made it possible to build under Windows. To further increase the support for the windows platform this commit moves the option for TBS TCTI that is being introduced in parallaxsecond#523 into a separate commit. This commit also updates the documentation regarding building using an installation folder. Co-author: Thomas Epperson <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>

When parallaxsecond#477 got merged it became possible to build using a path to the ```tpm2-tss``` installation instead of depending on ```pkg-config```. This made it possible to build under Windows. To further increase the support for the windows platform this commit moves the option for TBS TCTI that is being introduced in parallaxsecond#523 into a separate commit. This commit also updates the documentation regarding building using an installation folder. Co-authored-by: Thomas Epperson <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>

Superhepper force-pushed the win-build branch 2 times, most recently from 5c31929 to cef6a40 Compare December 10, 2023 10:24

Superhepper force-pushed the win-build branch 5 times, most recently from 6e7cfcb to 89a476e Compare December 18, 2023 20:57

Superhepper force-pushed the win-build branch from 89a476e to 1c17a57 Compare January 26, 2024 12:42

Superhepper force-pushed the win-build branch 20 times, most recently from c80915e to 5bf565c Compare March 26, 2024 14:12

Superhepper force-pushed the win-build branch from a2352e7 to 984a4f0 Compare March 30, 2024 10:59

ionut-arm reviewed Apr 1, 2024

View reviewed changes

Superhepper force-pushed the win-build branch from 984a4f0 to 7ab6abf Compare April 2, 2024 13:18

Superhepper requested review from ionut-arm, wiktor-k, hug-dev, tgonzalezorlandoarm and gowthamsk-arm April 3, 2024 18:51

ionut-arm reviewed Apr 6, 2024

View reviewed changes

ionut-arm approved these changes Apr 6, 2024

View reviewed changes

wiktor-k approved these changes Apr 8, 2024

View reviewed changes

Superhepper merged commit b75d2ad into parallaxsecond:main Apr 8, 2024
12 checks passed

Superhepper mentioned this pull request Apr 8, 2024

Add Ci for Windows #518

Open

Superhepper mentioned this pull request Apr 20, 2024

Windows TCTI/TBS support #421

Open

Superhepper mentioned this pull request Sep 13, 2024

Adds a TBS TctiNameConf. #545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for non pkg-config tpm2-tss installs. #477

Adds support for non pkg-config tpm2-tss installs. #477

Superhepper commented Dec 9, 2023 •

edited

Loading

wiktor-k commented Dec 10, 2023

Superhepper commented Dec 10, 2023

wiktor-k commented Mar 29, 2024

ionut-arm left a comment

ionut-arm Apr 1, 2024

Superhepper Apr 1, 2024

Superhepper Apr 1, 2024

wiktor-k Apr 2, 2024

ionut-arm Apr 6, 2024

ionut-arm left a comment

wiktor-k commented Apr 8, 2024

Superhepper commented Apr 8, 2024 •

edited

Loading

Adds support for non pkg-config tpm2-tss installs. #477

Adds support for non pkg-config tpm2-tss installs. #477

Conversation

Superhepper commented Dec 9, 2023 • edited Loading

wiktor-k commented Dec 10, 2023

Superhepper commented Dec 10, 2023

wiktor-k commented Mar 29, 2024

ionut-arm left a comment

Choose a reason for hiding this comment

ionut-arm Apr 1, 2024

Choose a reason for hiding this comment

Superhepper Apr 1, 2024

Choose a reason for hiding this comment

Superhepper Apr 1, 2024

Choose a reason for hiding this comment

wiktor-k Apr 2, 2024

Choose a reason for hiding this comment

ionut-arm Apr 6, 2024

Choose a reason for hiding this comment

ionut-arm left a comment

Choose a reason for hiding this comment

wiktor-k commented Apr 8, 2024

Superhepper commented Apr 8, 2024 • edited Loading

Superhepper commented Dec 9, 2023 •

edited

Loading

Superhepper commented Apr 8, 2024 •

edited

Loading