Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the tpm2-tss version for bindings. #505

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Superhepper
Copy link
Collaborator

@Superhepper Superhepper commented Feb 24, 2024

Fixes #496

  • Generate the bindings from version 3.2.2 of the tpm2-tss library.
  • Add comment in the generated bindings from what version it was generated.

@wiktor-k
Copy link
Collaborator

I'm in favor of this PR but I've noticed that the bindgen versions need to somehow align with parsec: parallaxsecond/rust-cryptoki#199 (comment) (I'm not saying there's a conflict, just noticed a similar PR in cryptoki).

@Superhepper
Copy link
Collaborator Author

I'm in favor of this PR but I've noticed that the bindgen versions need to somehow align with parsec: parallaxsecond/rust-cryptoki#199 (comment) (I'm not saying there's a conflict, just noticed a similar PR in cryptoki).

I have removed that for now. It can be changed at a later stage if necessary.

wiktor-k
wiktor-k previously approved these changes Feb 26, 2024
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... it's bunch of generated code so there's not much to review here anyway :)

tss-esapi/tests/Dockerfile-ubuntu Show resolved Hide resolved
- Generate the bindings from version 3.2.2 of the
  tpm2-tss library.

- Add comment in the generated bindings from what
  version it was generated.

- Starts using an explicit 4.0.1 version in tests.

Signed-off-by: Jesper Brynolf <[email protected]>
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Superhepper Superhepper merged commit e818ff6 into parallaxsecond:main Mar 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change minimum required tpm2-tss version.
3 participants