Settings tabs- add scrolling and work without DEV_NOISY (#1087)

paranext · Aug 22, 2024 · 2cf01cb · 2cf01cb
2 parents 52a5948 + 06280cf
commit 2cf01cb
Show file tree

Hide file tree

Showing 8 changed files with 132 additions and 120 deletions.
diff --git a/lib/platform-bible-react/dist/index.cjs b/lib/platform-bible-react/dist/index.cjs
diff --git a/lib/platform-bible-react/dist/index.cjs.map b/lib/platform-bible-react/dist/index.cjs.map
diff --git a/lib/platform-bible-react/dist/index.js b/lib/platform-bible-react/dist/index.js
diff --git a/lib/platform-bible-react/dist/index.js.map b/lib/platform-bible-react/dist/index.js.map
diff --git a/lib/platform-bible-react/src/components/advanced/navigation-content-search.component.tsx b/lib/platform-bible-react/src/components/advanced/navigation-content-search.component.tsx
@@ -39,7 +39,7 @@ export default function NavigationContentSearch({
 }: NavigationContentSearchProps) {
   return (
     <div className="pr-twp">
-      <div className="pr-space-y-2 pr-pb-2">
+      <div className="pr-sticky pr-top-0 pr-space-y-2 pr-pb-2">
         {headerTitle ? <h1>{headerTitle}</h1> : ''}
         <SearchBar
           isFullWidth={isSearchBarFullWidth}

diff --git a/...tform-bible-react/src/components/advanced/settings-components/settings-list.component.tsx b/...tform-bible-react/src/components/advanced/settings-components/settings-list.component.tsx
@@ -51,7 +51,9 @@ export function SettingsListItem({
     <div className="pr-flex pr-items-center pr-justify-between pr-space-x-4 pr-py-2">
       <div>
         <p className="pr-text-sm pr-font-medium pr-leading-none">{primary}</p>
-        <p className="pr-text-sm pr-text-muted-foreground">{secondary}</p>
+        <p className="pr-whitespace-normal pr-break-words pr-text-sm pr-text-muted-foreground">
+          {secondary}
+        </p>
       </div>
 
       {isLoading ? (

diff --git a/src/renderer/components/docking/platform-dock-layout-storage.util.ts b/src/renderer/components/docking/platform-dock-layout-storage.util.ts
@@ -90,6 +90,8 @@ if (globalThis.isNoisyDevModeEnabled) {
     [TAB_TYPE_WEBVIEW, loadWebViewTab],
     [TAB_TYPE_DOWNLOAD_UPDATE_PROJECT_DIALOG, loadDownloadUpdateProjectTab],
     [TAB_TYPE_EXTENSION_MANAGER, loadExtensionManagerTab],
+    [TAB_TYPE_USER_SETTINGS_TAB, loadUserSettingsTab],
+    [TAB_TYPE_PROJECT_SETTINGS_TAB, loadProjectSettingsTab],
     ...Object.entries(DIALOGS).map(
       ([dialogTabType, dialogDefinition]) =>
         // The default implementation of `loadDialog` uses `this`, so bind it to the definition

diff --git a/src/renderer/components/settings-tabs/settings-tab.component.scss b/src/renderer/components/settings-tabs/settings-tab.component.scss
@@ -1,3 +1,5 @@
 .settings-tab {
-  padding: 2%;
+  padding: 0 2% 2%;
+  height: inherit;
+  overflow-y: auto;
 }